chore(e2e): update to e2e-spec #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you point me the issue or the styleguide chapter this is solving? |
|
And here is the style recommendation: https://angular.io/docs/ts/latest/guide/style-guide.html#!#style-02-11 |
|
Thanks @Shyam-Chen! |
devCrossNet
pushed a commit
to devCrossNet/universal-cli
that referenced
this pull request
Jun 9, 2016
* Update protractor.conf.js * Rename app.e2e.ts to app.e2e-spec.ts
devCrossNet
pushed a commit
to devCrossNet/universal-cli
that referenced
this pull request
Jun 9, 2016
* Update protractor.conf.js * Rename app.e2e.ts to app.e2e-spec.ts reverted live-reload: we have to find another solution for this; added ngOnRendered event; updated to latest universal version added support and tests for 'ng new app --universal --mobile' start-node: added environment support
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.